Fix the docker_compose options parameter position #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
I was just perusing the code, and happened to notice ... this PR fixes the args array ordering on one line of the affected file, but there are five more instances of the exact same bug later on in the file, which also (still!) need fixing. All occurrences of "insert(2, ..." should be "insert(3, ". |
|
Encountered the same problem. |
awegmann
added a commit
to awegmann/puppetlabs-docker
that referenced
this pull request
Jul 8, 2020
…petlabs#378' The fix done in 2018 was not complete. There were five more code lines which inserted the optional parameters at the wrong position.
daianamezdrea
added a commit
that referenced
this pull request
Jul 16, 2020
Fixing the fix 'Fix the docker_compose options parameter position #378'
rbelnap
pushed a commit
to rbelnap/puppetlabs-docker
that referenced
this pull request
Oct 19, 2020
…petlabs#378' The fix done in 2018 was not complete. There were five more code lines which inserted the optional parameters at the wrong position.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix move the potion of docker-compose options from this:
/usr/local/bin/docker-compose -p --project-directory /path name up -d --remove-orphansto this:
/usr/local/bin/docker-compose -p name --project-directory /path up -d --remove-orphans