Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bypassing curl package ensure if needed #477

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

esalberg
Copy link
Contributor

Even with ensure_packages, there can be resource duplication errors if the parameters do not match. Add an option not to ensure the curl package (curl package is ensured by default to maintain status quo).

@esalberg
Copy link
Contributor Author

rebased.

@esalberg
Copy link
Contributor Author

rebased.

@esalberg
Copy link
Contributor Author

Spec is fixed.

@lionce
Copy link
Contributor

lionce commented Jul 19, 2019

Hello @esalberg ,

This looks good for me, but would it be possible to add some tests to verify that this is working as intended? Thanks.

Cheers!

@sheenaajay
Copy link
Contributor

Hello @esalberg, Please let us know if you need any help or information on adding the tests to verify the changes.Thanks for submitting the PR.

@lionce
Copy link
Contributor

lionce commented Nov 7, 2019

Hello @esalberg ,

Please let us know if you're still working on this PR and if we can help you! Thanks!

Cheers!

@david22swan
Copy link
Member

@esalberg Sorry to keep pinging, but is there any chance that you're gonna come back and finish this?

@esalberg esalberg requested a review from a team as a code owner April 2, 2020 15:24
@david22swan
Copy link
Member

Have rebased the work on current master and pushed up

@codecov-io
Copy link

codecov-io commented Apr 2, 2020

Codecov Report

Merging #477 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #477   +/-   ##
=======================================
  Coverage   28.02%   28.02%           
=======================================
  Files          19       19           
  Lines         685      685           
=======================================
  Hits          192      192           
  Misses        493      493           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9acae89...953a6c6. Read the comment docs.

@david22swan david22swan merged commit d498423 into puppetlabs:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants