-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow bypassing curl package ensure if needed #477
Conversation
rebased. |
rebased. |
Spec is fixed. |
Hello @esalberg , This looks good for me, but would it be possible to add some tests to verify that this is working as intended? Thanks. Cheers! |
Hello @esalberg, Please let us know if you need any help or information on adding the tests to verify the changes.Thanks for submitting the PR. |
Hello @esalberg , Please let us know if you're still working on this PR and if we can help you! Thanks! Cheers! |
@esalberg Sorry to keep pinging, but is there any chance that you're gonna come back and finish this? |
Have rebased the work on current master and pushed up |
Codecov Report
@@ Coverage Diff @@
## master #477 +/- ##
=======================================
Coverage 28.02% 28.02%
=======================================
Files 19 19
Lines 685 685
=======================================
Hits 192 192
Misses 493 493 Continue to review full report at Codecov.
|
Even with ensure_packages, there can be resource duplication errors if the parameters do not match. Add an option not to ensure the curl package (curl package is ensured by default to maintain status quo).