Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add after_start and after_stop options to docker::run define #580

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

jantman
Copy link
Contributor

@jantman jantman commented Feb 26, 2020

This pull request adds after_start and after_stop parameters to the docker::run define, working similarly to the existing before_start and before_stop options (i.e. these execute a command after the container is started or stopped).

PR includes unit tests. I haven't added these to the acceptance tests as the existing before_ variants weren't being tested there, but these are relatively simple template changes and we're currently using this code.

@jantman jantman requested a review from a team as a code owner February 26, 2020 13:14
@codecov-io
Copy link

codecov-io commented Feb 26, 2020

Codecov Report

Merging #580 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #580   +/-   ##
=======================================
  Coverage   28.02%   28.02%           
=======================================
  Files          19       19           
  Lines         685      685           
=======================================
  Hits          192      192           
  Misses        493      493

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0196436...0783f9f. Read the comment docs.

@sheenaajay
Copy link
Contributor

Thanks, @jantman for submitting the PR. Great work.

@sheenaajay sheenaajay merged commit 031e699 into puppetlabs:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants