Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IAC-291] Convert acceptance tests to Litmus #585

Merged
merged 6 commits into from
Apr 7, 2020
Merged

[IAC-291] Convert acceptance tests to Litmus #585

merged 6 commits into from
Apr 7, 2020

Conversation

carabasdaniel
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 10, 2020 •
edited
Loading

Codecov Report

Merging #585 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #585   +/-   ##
=======================================
  Coverage   28.02%   28.02%           
=======================================
  Files          19       19           
  Lines         685      685           
=======================================
  Hits          192      192           
  Misses        493      493

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6174b52...396893b. Read the comment docs.

@carabasdaniel carabasdaniel changed the title [WIP] Convert acceptance tests to Litmus [IAC-291] Convert acceptance tests to Litmus Mar 10, 2020
@carabasdaniel carabasdaniel marked this pull request as ready for review March 10, 2020 15:57
@carabasdaniel carabasdaniel requested a review from a team as a code owner March 10, 2020 15:57
@carabasdaniel carabasdaniel force-pushed the litmus branch 21 times, most recently from 99b416f to 7c0815d Compare March 12, 2020 12:03
sanfrancrisko
sanfrancrisko reviewed Mar 12, 2020
View reviewed changes
Copy link
Contributor

@sanfrancrisko sanfrancrisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @carabasdaniel . Just a few comments

@carabasdaniel carabasdaniel force-pushed the litmus branch 2 times, most recently from 8f012a6 to d09ea62 Compare April 7, 2020 09:15
@sheenaajay sheenaajay merged commit d0db0b9 into puppetlabs:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanfrancrisko sanfrancrisko sanfrancrisko left review comments

@sheenaajay sheenaajay sheenaajay approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carabasdaniel @codecov-io @sheenaajay @sanfrancrisko