Blocking ordering between non-Windows service stops #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows based services stopping will block until the docker container stops (ie: if docker::run::stop_wait_time has been set to !=0) service based stops do not - this adds that dependency in so that containers are not attempted to be removed until the service has stopped
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
=======================================
Coverage 27.94% 27.94%
=======================================
Files 19 19
Lines 680 680
=======================================
Hits 190 190
Misses 490 490 Continue to review full report at Codecov.
|
|
Hi @ALTinners, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows based services stopping will block until the docker container stops (ie: if
docker::run::stop_wait_timehas been set to !=0)servicebased stops do not - this adds that dependency in so that containers are not attempted to be removed until the service has stopped