-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker swarm join-tokens as facts #651
Add docker swarm join-tokens as facts #651
Conversation
Travis seems to time out only on |
@oschusler Took a quick look at your pr and it all looks fine but would need some changes before it can be merged in. For a PR such as this both updated test's and docs would be needed, to ensure that the functionality works as is intended and make it so that people can easily understand it's function. |
@david22swan thank you for your comments. I will add the documentation and tests. Could you however perhaps explain to me why Travis is failing? I complains that it didn't receive any logging in the last 10 minutes, while the last log statement was that all tests passed. |
Codecov Report
@@ Coverage Diff @@
## main #651 +/- ##
==========================================
- Coverage 25.64% 22.37% -3.28%
==========================================
Files 20 20
Lines 741 751 +10
==========================================
- Hits 190 168 -22
- Misses 551 583 +32
Continue to review full report at Codecov.
|
@oschusler From what I know there was a problem with our code coverage tool that was causing it to hang indefinitely. A fix has gone in though so there should be no more problems. |
45cea90
to
8cac029
Compare
@david22swan I think the PR is ready, could you have a look at it? |
@oschusler Apologies for the wait, taking a look through I would say I am happy with what you have done and feel good about merging it. |
Fix for issue #638.
This PR adds 2 facts to PuppetDB (
worker_join_token
andmanager_join_token
). The puppet agent will have to be run twice, once to setup the docker manager, and a second time to send the updated fact to PuppetDB. Combined with the following snippet, a docker cluster can be started up, unsupervised: