Ensure image digest checksum before starting

[tmanninger]

Hi,

i added an option to make sure, that the image is not modified before starting the image.

[puppet-community-rangefinder]

docker::run is a type

Breaking changes to this file WILL impact these 6 modules (exact match):

• gennadyvoronkov-dcos
• puppetlabs-cd4pe
• ffquintella-dockerapp
• samuelson-dockeragent
• dodevops-hanaexpress
• glorpen-g_docker

Breaking changes to this file MAY impact these 21 modules (near match):

• KyleAnderson-consul
• autostructure-secure_docker
• jefferyb-kualicoeus
• cristifalcas-docker_auth
• puppetlabs-rancher
• pltraining-puppetfactory
• pltraining-classroom_legacy
• cristifalcas-prometheus
• bfraser-grafana
• cristifalcas-docker_distribution
• cjtoolseram-drone
• factorit-grafana
• justin8-ghost
• c0deaddict-gogs
• prozeta-portauthority
• nick-rancher
• cristifalcas-kubernetes
• pltraining-dockeragent
• puppet-grafana
• flyer-docker_cluster
• pltraining-classroom

This module is declared in 6 of 575 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[adrianiurca]

Hi @tmanninger, can you add an acceptance test to ensure that all works properly, and after we will be able to merge your contribution. Please ask for any help!

Kind regards,
@adrianiurca

[tmanninger]

Hi @adrianiurca, i added 2 accpetance tests, could you please review?

Edit: why all the docker::run tests (and also my digest check) are not executed?

[codecov-io]

Codecov Report

Merging #673 into main will increase coverage by 0.40%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
+ Coverage   22.19%   22.60%   +0.40%     
==========================================
  Files          20       20              
  Lines         757      761       +4     
==========================================
+ Hits          168      172       +4     
  Misses        589      589              

Impacted Files	Coverage Δ
lib/puppet/provider/docker_network/ruby.rb	53.84% <0.00%> (+3.84%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a2a029...afb0249. Read the comment docs.

[adrianiurca]

Hi @tmanninger, thank you for your contribution!

kind regards,
@adrianiurca