Skip to content

Added compatibility with facter 2.4.6 puppetlabs#626 #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

Tozapid
Copy link
Contributor

@Tozapid Tozapid commented Oct 26, 2020

This is a simple check that we used facter 2.4.6, It's working fine on Debian 9

@Tozapid Tozapid requested a review from a team as a code owner October 26, 2020 11:56
@puppet-community-rangefinder
Copy link

docker::params is a class

that may have no external impact to Forge modules.

docker::repos is a class

that may have no external impact to Forge modules.

This module is declared in 6 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-io
Copy link

codecov-io commented Oct 26, 2020

Codecov Report

Merging #674 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #674   +/-   ##
=======================================
  Coverage   22.60%   22.60%           
=======================================
  Files          20       20           
  Lines         761      761           
=======================================
  Hits          172      172           
  Misses        589      589           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec3159f...578d8b2. Read the comment docs.

@adrianiurca
Copy link
Contributor

Hi @Tozapid, thank you for your contribution!

@adrianiurca adrianiurca merged commit c741a9c into puppetlabs:main Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants