Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix systemd units for systemd versions < v230 #704

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

benningm
Copy link
Contributor

@benningm benningm commented Jan 8, 2021

This will revert the change introduced in 2675ed7 for
systems with systemd versions older than v230 as these systemd
versions dont support StartLimitIntervalSec and StartLimitBurst
in [Unit] sections causing:

Unknown lvalue 'StartLimitIntervalSec' in section 'Unit'
Unknown lvalue 'StartLimitBurst' in section 'Unit'

related #456

This will revert the change introduced in 2675ed7 for
systems with systemd versions older than v230 as these systemd
versions dont support StartLimitIntervalSec and StartLimitBurst
in [Unit] sections causing:

  Unknown lvalue 'StartLimitIntervalSec' in section 'Unit'
  Unknown lvalue 'StartLimitBurst' in section 'Unit'

related puppetlabs#456
@benningm benningm requested a review from a team as a code owner January 8, 2021 10:28
@puppet-community-rangefinder
Copy link

docker is a class

Breaking changes to this file WILL impact these 14 modules (exact match):
Breaking changes to this file MAY impact these 23 modules (near match):

docker::params is a class

that may have no external impact to Forge modules.

This module is declared in 6 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-io
Copy link

codecov-io commented Jan 8, 2021

Codecov Report

Merging #704 (e169577) into main (90725bb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #704   +/-   ##
=======================================
  Coverage   23.42%   23.42%           
=======================================
  Files          20       20           
  Lines         760      760           
=======================================
  Hits          178      178           
  Misses        582      582           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90725bb...e169577. Read the comment docs.

@adrianiurca
Copy link
Contributor

HI @benningm, thank you for your contribution!

@adrianiurca adrianiurca self-assigned this Jan 11, 2021
@adrianiurca adrianiurca merged commit 284a7d3 into puppetlabs:main Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants