Prefer timeout to time_limit for Facter::Core::Execution #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Facter 4 documentation and code was inconsistent regarding naming of this option. `limit` and `time_limit` have been replaced by `timeout` which also match the option name in previous versions of facter. The old names will output a warning when used, so swith to the new terminology now. Releated PR: puppetlabs/facter#2429
|
Build failure unrelated. |
adrianiurca
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facter 4 documentation and code was inconsistent regarding naming of
this option.
limitandtime_limithave been replaced bytimeoutwhich also match the option name in previous versions of facter. The
old names will output a warning when used, so swith to the new
terminology now.
Releated PR:
puppetlabs/facter#2429