Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only install docker-ce-cli with docker-ce #827

Merged
merged 1 commit into from
May 6, 2022
Merged

Only install docker-ce-cli with docker-ce #827

merged 1 commit into from
May 6, 2022

Conversation

vchepkov
Copy link
Contributor

@vchepkov vchepkov commented May 5, 2022

rebase to main of #798

@kenyon @vchepkov
Only install docker-ce-cli with docker-ce
81c14ff 
In puppetlabs#740 I mistakenly added code that manages the docker-ce-cli package
when managing the "docker" package. The docker-ce-cli package should
only be managed when also managing the docker-ce package.

Fixes puppetlabs#797
@vchepkov vchepkov requested a review from a team as a code owner May 5, 2022 15:04
@puppet-community-rangefinder
Copy link

docker::install is a class

that may have no external impact to Forge modules.

This module is declared in 6 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@vchepkov vchepkov mentioned this pull request May 5, 2022
Closed
@vchepkov
Copy link
Contributor Author

vchepkov commented May 5, 2022

I have no idea why identical change on master succeeded and on top on main failed.
I see @kenyon is back, so I am happy to bug out

@chelnak
Copy link
Contributor

chelnak commented May 5, 2022

It could be transient windows issues. We can re kick the tests.

@kenyon
Copy link
Contributor

kenyon commented May 5, 2022

The Windows test failures are unrelated, apparently due to network problems.

@chelnak
Copy link
Contributor

chelnak commented May 6, 2022

@kenyon Yeah thats right. Windows can be a bit flakey sometimes. Looks like we are all green now though.

@chelnak chelnak merged commit 965cea5 into puppetlabs:main May 6, 2022
@vchepkov vchepkov deleted the docker-ce-cli-fix branch May 11, 2022 14:05
@chelnak chelnak added the bugfix label May 16, 2022
@antaflos antaflos mentioned this pull request Oct 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenyon kenyon kenyon approved these changes

@chelnak chelnak chelnak approved these changes

Assignees
No one assigned
Labels
bugfix community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vchepkov @chelnak @kenyon @ia-content