Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New create_user parameter on main class #841

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

traylenator
Copy link
Contributor

Currently when specifying docker_users every user is
both created and added to the docker group.

If create_user is false then the users are presumed to exist
via another method outside this module and will only be added to
the docker group.

Fixes #840

Currently when specifying `docker_users` every user is
both created and added to the docker group.

If `create_user` is false then the users are presumed to exist
via another method outside this module and will only be added to
the docker group.

Fixes puppetlabs#840
@CLAassistant
Copy link

CLAassistant commented Jun 7, 2022

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

docker::config is a class

that may have no external impact to Forge modules.

docker is a class

Breaking changes to this file WILL impact these 17 modules (exact match):
Breaking changes to this file MAY impact these 24 modules (near match):

This module is declared in 6 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@traylenator traylenator marked this pull request as ready for review June 7, 2022 09:12
@traylenator traylenator requested a review from a team as a code owner June 7, 2022 09:12
@traylenator
Copy link
Contributor Author

CLA has been signed on behalf of CERN IT with PuppetLabs.

Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable!

@petergmurphy petergmurphy merged commit b256772 into puppetlabs:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker::system_user::create_user is not exposed.
6 participants