adding optional variable for package_key_check_source to RedHat

[STaegtmeier]

Change the hard coded value for $package_key_check_source for RedHat to the optional variable $docker_package_key_check_source.
The variable is already used further down in the following else-block for RedHat.
The optional var is defined as true within the params.pp so there should be no following issues.

The change is needed for one of my customers which used an own yum-repo for the docker repository, were the values must be set to false.

[puppet-community-rangefinder]

docker is a class

Breaking changes to this file WILL impact these 17 modules (exact match):

• puppetlabs-cd4pe
• martyewings-githubactionboard
• puppetlabs-data_entitlement
• simp-simp_docker
• tomkrieger-remediate_install
• maeq-storj
• samuelson-dockeragent
• gennadyvoronkov-dcos
• autostructure-docker_ee
• fervid-docker_ee
• ffquintella-dockerapp
• knoppi-jitsi
• glorpen-g_docker
• dodevops-hanaexpress
• walkamongus-harbor
• mindhive-nvidia_docker_runtime
• maany-simple_grid

Breaking changes to this file MAY impact these 24 modules (near match):

• tsuru-registry
• tsuru-redis_service
• pltraining-selfpaced
• tsuru-router
• c0deaddict-gogs
• flyer-docker_cluster
• maasch-iot_provisioning
• jantman-archlinux_workstation
• nick-rancher
• scottyc-docker_swarm
• justin8-ghost
• autostructure-secure_docker
• jefferyb-kualicoeus
• pltraining-classroom_legacy
• cristifalcas-flannel
• pltraining-classroom
• puppet-gitlab_ci_runner
• Azcender-profile
• pltraining-dockeragent
• praekeltfoundation-seed_stack
• pltraining-puppetfactory
• prozeta-portauthority
• hesco-weave
• vshn-gitlab

This module is declared in 6 of 579 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[CLAassistant]

All committers have signed the CLA.

[chelnak]

@STaegtmeier Thanks for the contribution.

Should the following line also consume the docker_package_key_check_source variable?

puppetlabs-docker/manifests/init.pp

Line 573 in 30d37d6

$package_key_check_source = true

[chelnak]

Thanks for making the change. This looks fine now.

[chelnak]

The Server 2016 failures are not related to this PR so I'm happy to get this merged.

Thanks for your contribution!