Use puppet yaml helper to workaround psych >4 breaking changes #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @gfargeas. Could rebase your branch with main? |
…ing positional arguments
|
@GSPatton , everything is now up-to-date. |
|
Hi @GSPatton, anything else needed regarding this PR? |
|
Looks like our tests didnt properly kick in last time there was a push. Closing and re-opening PR to restart them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue occurs with Psych >= 4 and breaks docker_compose command in my case.
The safe_ load method in puppet helper is there since a while so no need to change puppet version requirements here.