Fix docker fact with recent version of docker
#897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `docker` nested fact is supposed to be conditionaly build if the docker client version is 1.13 or greater, as changed in #166. Unfortunately, the regexp is not working as expected, and future tweaks of the regexp did not fix it. Fix the regexp to match versions greater are equal to 1.13.*. Add a few unit tests to verify the outcome. Fixes #896
smortex
force-pushed
the
fix-facter-version-matching
branch
from
4e4ce92 to
ddb5092
Compare
bastelfreak
previously approved these changes
Feb 14, 2023
|
After restarting the failing builds 8 times, it finally passed ✌️ |
|
Please merge this with the mainstream ASAP, as new docker versions aren't detected by the old regexp and therefore the module currently requires patching downstream before use. |
|
I can't set up a lower docker version on Ubuntu focal. This configuration installs the latest 23.0.1 docker version. |
|
Thanks for you contribution! |
|
@vitargelo If you are still experiencing problems, please raise an issue in our Issues section. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dockernested fact is supposed to be conditionaly build if thedocker client version is 1.13 or greater, as changed in #166.
Unfortunately, the regexp is not working as expected, and future tweaks
of the regexp did not fix it.
Fix the regexp to match versions greater are equal to 1.13.*. Add a few
unit tests to verify the outcome.
Fixes #896