pdksync - (MAINT) - Require Stdlib 9.x #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR currently blocked by main CI failing. Issues are not related to change afaics |
smortex
force-pushed
the
pdksync_CONT-1028-update-stdlib-dependency
branch
from
aa054ec to
fd40b54
Compare
bastelfreak
previously approved these changes
Jun 5, 2023
smortex
force-pushed
the
pdksync_CONT-1028-update-stdlib-dependency
branch
from
fd40b54 to
7bfda16
Compare
LukasAud
changed the title
|
I think the PR title should be adjusted. this now doesn't allow stdlib 9, it requires it (which is in my opinion a breaking change). |
LukasAud
changed the title
smortex
requested changes
Jun 12, 2023
Ramesh7
approved these changes
Jun 13, 2023
|
These windows failure seems quite reproducible. I have basically no experience with docker and windows, but it looks like the command we run do not match the ones from upstream documentation: vs. Can't say if we do this by mistake or on purpose. |
|
This PR is failing due to problems present on main. This does not create any new failures on top on the already existing ones afaik. We should be able to merge this and address failures on main in a different place. |
LukasAud
force-pushed
the
pdksync_CONT-1028-update-stdlib-dependency
branch
from
f462aa1 to
23b1bf9
Compare
This deprecated function was removed from Puppet. The Puppet 4 type system can be used to ensure the validity of parameters with better error reporting.
Co-authored-by: Romain Tartière <[email protected]>
LukasAud
force-pushed
the
pdksync_CONT-1028-update-stdlib-dependency
branch
from
23b1bf9 to
bfc3422
Compare
jordanbreen28
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(MAINT) - Update Stdlib dependency
pdk version:
2.7.0