remove stats as default #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be merged. It is indeed a bad practice to enable stats on every frontend by default. |
|
any update on this ? |
|
Maybe @skyamgarp can help ? |
|
@elfranne could you please fix the failing specs & squash the commits later? |
|
let's see if the tests works this time. |
|
This is a security issue. By default this module opens stats to the whole public, and the option can be just set to |
|
You can always add stats where you want with authentication, I just don't want to be enabled as default everywhere. |
|
Since the new merge_options parameter defaults to true, every single installation that decided to use custom options to disable 'stats enabled' will get it automatically back as side effect. |
PF-3525 : pdk update for module (CAT-2101) Add support for Debian-12 (CAT-2101) test comit (CAT-2101) test commit (CAT-2158) Upgrade rexml to address CVE-2024-49761 remove stats from checks
span786
approved these changes
Jan 30, 2025
amitkarsale
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #590
This is not a default parameter from Haproxy, and is bad practice to open up stats to all.
This is also not enabled on BSD.