Ensure correct scheduler extra arguments passed to v1beta3 template #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
deric
previously approved these changes
Dec 30, 2023
|
Looks good, it would be nice to have some tests for this feature. |
|
@deric I've added some unit tests |
treydock
force-pushed
the
v1beta3-extra-args
branch
from
53132ca to
9f5a9c5
Compare
|
@treydock Thanks, looks good. The centos failure seems to be unrelated. |
deric
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The v1beta3 template needs to use correct argument to get the scheduler extra args.
Additional Context
I upgraded from 6.0.0 to 8.0.0 and lost some changes:
The Hiera I have is this:
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)