(MODULES-6923) Migrate from puppet-staging to puppet-archive #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbadia
force-pushed
the
migrate-to-archive
branch
from
a208430 to
f30bec5
Compare
hunner
reviewed
Mar 29, 2018
manifests/server/mysqltuner.pp
Outdated
| @@ -3,52 +3,20 @@ | |||
| $ensure = 'present', | |||
| $version = 'v1.3.0', | |||
| $source = undef, | |||
| $environment = undef, # environment for staging::file | |||
| $environment = undef, # UNUSED (puppetlabs-mysql 5.3.0) | |||
There was a problem hiding this comment.
It's already a breaking change to add a new dependency, so we can just go ahead and remove this parameter.
There was a problem hiding this comment.
ack, thanks @hunner for the review !
hunner
approved these changes
Mar 29, 2018
sbadia
force-pushed
the
migrate-to-archive
branch
from
f30bec5 to
7dbf303
Compare
|
Hi here, Oh, the major version 6.0.0 was released without this simple change :-/ Please see voxpupuli/puppet-staging#162 |
|
@sbadia Apologies on the wait. If you could rebase you changes I would be happy to take a look at your PR. |
|
Hi @david22swan ! No problem :-) Finally MOD-6923 was fixed by @tphoney in the PR-1115. I close this one, Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The voxpupuli puppet-staging module is deprecated since ±1y, please see puppet-staging deprecation notice, we recomand to migrate to puppet-archive module (also maintained by voxpupuli team).
Staging module is only used for the mysql tunner script.