-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for RHSCL mysql versions and support for .mylogin.cnf for MySQL 5.6.6+ #1061
Conversation
@@ -21,6 +21,8 @@ | |||
$service_provider = $mysql::params::server_service_provider, | |||
$create_root_user = $mysql::params::create_root_user, | |||
$create_root_my_cnf = $mysql::params::create_root_my_cnf, | |||
$create_root_login_file = $mysql::params::create_root_login_file, | |||
$login_file = $mysql::params::login_file, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the expected workflow of passing a login file? Why is it using the source
parameter instead of content
? Where does it come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to create the login file first with mysql_config_editor, this creates an encrypted file.
And because the tool uses interactive prompt for the password, it's not possible to create during a puppet run.
So that's why you need to source this instead of using content.
https://dev.mysql.com/doc/refman/5.6/en/mysql-config-editor.html
@DJMuggs Is there any movement on this pr? |
Allow use of .mylogin.cnf for mysql 5.6 and up.
rebased it |
@DJMuggs If possible could you add an acceptance test to the module to cover the use of |
Creating this file goes through an interactive password prompt, so this not possible at the moment. |
@DJMuggs Merged. Thanks for the work you put in. |
Added support for RHSCL versions.
We need additional LD_LIBRARY_PATH paths for RHSCL.
Fixed db import when using RHSCL, allow to extend the default path to find the mysql executable.
Allow support for .mylogin.cnf when using MySQL 5.6+.
We cannot generate this file from puppet so we need to provide one ourselves.