Skip to content

Fix failing syntax tests #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix failing syntax tests #1085

wants to merge 1 commit into from

Conversation

pasuder
Copy link

@pasuder pasuder commented May 29, 2018

Due to RuboCop settings, usage of %w[] was not working correctly. That change fixes that.

Link to failed job: https://travis-ci.org/puppetlabs/puppetlabs-mysql/jobs/384698082

Offenses:
spec/functions/mysql_deepmerge_spec.rb:23:18: C: Style/WordArray: Use [] for an array of words. (https://github.com/bbatsov/ruby-style-guide#percent-w)
  index_values = %w[one two three]
                 ^^^^^^^^^^^^^^^^^
spec/functions/mysql_deepmerge_spec.rb:24:25: C: Style/WordArray: Use [] for an array of words. (https://github.com/bbatsov/ruby-style-guide#percent-w)
  expected_values_one = %w[1 2 2]
                        ^^^^^^^^^
spec/functions/mysql_deepmerge_spec.rb:62:22: C: Style/WordArray: Use [] for an array of words. (https://github.com/bbatsov/ruby-style-guide#percent-w)
  index_values_two = %w[key1 key2]
                     ^^^^^^^^^^^^^

Related to #1084

Due to RuboCop settings, usage of %w[] was not working
correctly. That change fixes that.

Related to #1084
@david22swan
Copy link
Member

@pasuder Rebase the PR and I will be happy to merge

@pmcmaw
Copy link
Contributor

pmcmaw commented Aug 14, 2018

@pasuder thank you for taking your time to contribute. I can confirm that this issue was resolved in the following commit: c9a9419

Apologies and thank you for contributing. I plan on closing your PR and if you disagree feel free to reopen.

Many Thanks
Paula

@pmcmaw pmcmaw closed this Aug 14, 2018
@pasuder
Copy link
Author

pasuder commented Aug 14, 2018

OK, great, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants