FM 7783 - Test Audit making testing more efficient #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmcmaw
reviewed
Feb 27, 2019
pmcmaw
reviewed
Feb 27, 2019
pmcmaw
requested changes
Feb 27, 2019
lionce
force-pushed
the
FM-7783
branch
2 times, most recently
from
280695b to
5959e5d
Compare
pmcmaw
reviewed
Feb 28, 2019
pmcmaw
reviewed
Feb 28, 2019
lionce
force-pushed
the
FM-7783
branch
4 times, most recently
from
cf2b58b to
dc4b26f
Compare
pmcmaw
reviewed
Feb 28, 2019
pmcmaw
reviewed
Feb 28, 2019
pmcmaw
reviewed
Feb 28, 2019
pmcmaw
reviewed
Mar 4, 2019
spec/acceptance/locales_spec.rb
Outdated
| @@ -1,7 +1,7 @@ | |||
| require 'spec_helper_acceptance' | |||
| require 'beaker/i18n_helper' | |||
|
|
|||
| describe 'mysql localization', if: (fact('osfamily') == 'Debian' || fact('osfamily') == 'RedHat') && (Gem::Version.new(puppet_version) >= Gem::Version.new('4.10.5')) do | |||
| describe 'mysql localization', if: (fact('osfamily') == 'debian' || fact('osfamily') == 'redhat') && (Gem::Version.new(puppet_version) >= Gem::Version.new('4.10.5')) do | |||
There was a problem hiding this comment.
fact('osfamily') will need to be changed to: os[:family]
This is removing facter from the codebase and using 'serverspec' instead, serverspec is faster than facter.
pmcmaw
reviewed
Mar 4, 2019
| @@ -31,20 +45,15 @@ | |||
| run_puppet_access_login(user: 'admin') if pe_install? && (Gem::Version.new(puppet_version) >= Gem::Version.new('5.0.0')) | |||
| hosts.each do |host| | |||
| # This will be removed, this is temporary to test localisation. | |||
| if (fact('osfamily') == 'Debian' || fact('osfamily') == 'RedHat') && | |||
There was a problem hiding this comment.
This localization code may be required, please double check in CI that localization tests run with no issues.
pmcmaw
changed the title
pmcmaw
approved these changes
Mar 4, 2019
alexjfisher
reviewed
Apr 28, 2020
| @@ -1,21 +0,0 @@ | |||
| # @summary | |||
There was a problem hiding this comment.
Removing this was a bad idea since https://github.com/puppetlabs/puppetlabs-mysql/blob/0a8f0054113c68b60f19e381f9452155b937b31b/lib/puppet/parser/functions/mysql_password.rb still exists...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effort has been realized by both myself and @Lavinia-Dan
https://jenkins-master-prod-1.delivery.puppetlabs.net/view/modules/view/linux/view/_adhoc/view/mysql/job/forge-module_puppetlabs-mysql_intn-sys_full-pe-current-adhoc/PLATFORM=redhat5-64default.a,WORKER_LABEL=beaker/