(MODULES-8886) Revert removal of deepmerge function #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eimlav
changed the title
Reverting this change as the deepmerge function in stdlib does not work the same as the mysql function. The mysql config is generated with incorrect duplicate entries in which '-' and '_' are mixed up when using the stdlib function.
eimlav
force-pushed
the
modules-8886
branch
3 times, most recently
from
caf4b13 to
a54ba60
Compare
eimlav
changed the title
|
Adhoc ran successfully: Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting this change as the deepmerge function in stdlib does not work the same as the mysql deepmerge. As a result, the mysql config is generated with incorrect duplicate entries with '-' and '_' mixed up.
Original PR #1145 @david22swan