(MODULES-10023) expose $incremental_backups parameter #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraenki
changed the title
|
Hello @fraenki , Thank you for this contribution. It would be possible to add a test under mysql_backup_xtrabackup_spec to test the new param please? Thanks! Cheers! |
DavidS
changed the title
|
This fix was incooporated into #1245. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tickets.puppetlabs.com/browse/MODULES-10023
In #1188 a new parameter
$incremental_backupswas added to the private classmysql::backup::xtrabackup.However, in order to be actually useful and for more convenience this parameter should also be added to the parent class
mysql::server::backupfrom which the private class is usually called with the appropiate parameters.