Remove control character from manifests/server.pp #1312

tomkrouper · 2020-06-30T21:37:30Z

A check for ascii characters revealed that the contraction for "do not"
was not a valid ascii character, this changes that.

resolves: https://tickets.puppetlabs.com/browse/MODULES-10723

A check for ascii characters revealed that the contraction for "do not" was not a valid ascii character, this changes that.

puppet-community-rangefinder · 2020-06-30T21:37:43Z

mysql::server is a class

Breaking changes to this file WILL impact these 74 modules (exact match):

Breaking changes to this file MAY impact these 50 modules (near match):

This module is declared in 142 of 575 indexed public `Puppetfiles`.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

codecov-commenter · 2020-06-30T22:18:42Z

Codecov Report

Merging #1312 into master will increase coverage by 5.45%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master    #1312      +/-   ##
==========================================
+ Coverage   50.23%   55.69%   +5.45%     
==========================================
  Files          22       22              
  Lines        1045     1045              
==========================================
+ Hits          525      582      +57     
+ Misses        520      463      -57

Impacted Files	Coverage Δ
lib/puppet/provider/mysql_user/mysql.rb	`87.58% <40.00%> (ø)`
...ppet/provider/mysql_login_path/mysql_login_path.rb	`90.32% <0.00%> (+61.29%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 207ba9c...c8b0817. Read the comment docs.

sheenaajay · 2020-07-01T11:34:28Z

Thank you @tomkrouper for submitting the PR.

Remove control character from manifests/server.pp

c8b0817

A check for ascii characters revealed that the contraction for "do not" was not a valid ascii character, this changes that.

tomkrouper requested a review from a team as a code owner June 30, 2020 21:37

sheenaajay added the bugfix label Jul 1, 2020

sheenaajay merged commit 16b1c8c into puppetlabs:master Jul 1, 2020

tomkrouper deleted the modules-10723 branch July 1, 2020 15:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove control character from manifests/server.pp #1312

Remove control character from manifests/server.pp #1312

tomkrouper commented Jun 30, 2020

puppet-community-rangefinder bot commented Jun 30, 2020

codecov-commenter commented Jun 30, 2020 •

edited

Loading

sheenaajay commented Jul 1, 2020

Remove control character from manifests/server.pp #1312

Remove control character from manifests/server.pp #1312

Conversation

tomkrouper commented Jun 30, 2020

puppet-community-rangefinder bot commented Jun 30, 2020

mysql::server is a class

This module is declared in 142 of 575 indexed public Puppetfiles.

codecov-commenter commented Jun 30, 2020 • edited Loading

Codecov Report

sheenaajay commented Jul 1, 2020

This module is declared in 142 of 575 indexed public `Puppetfiles`.

codecov-commenter commented Jun 30, 2020 •

edited

Loading