Skip to content

Add support for optional__args and prescript to mysqldump backup provider. #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

markleary
Copy link
Contributor

The mysqldump class already has the optional_args and prescript parameters but they were never implemented in the script template.

@JCotton1123
Copy link
Contributor

We're in need of this feature so that we can pass the --master-data=2 option to mysqldump, and use our backups for setting up slaves. What needs to happen to get this merged?

@david22swan
Copy link
Member

@markleary My apologies for the wait. In order to merge this PR into the master some manner of test coverage would have to be added to ensure that no problems arise now or in the future.

@david22swan
Copy link
Member

@markleary Is there any movement on this PR?

@markleary
Copy link
Contributor Author

@david22swan I'll try to take a look within the next few days and add tests.

@mjuszczak
Copy link

@markleary Just wanted to ping on this. Is there any movement? Do you need any help re: tests? Thank you!

@markleary
Copy link
Contributor Author

Sorry for the delay, what would you be looking for here as far as tests? Would a prescript test similar to the existing postscript one suffice? @mjuszczak if you have time and want to add the test feel free!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants