(maint) correct lint issues found on forge

Author: tkishel

Diff for: .puppet-lint.rc

@@ -1,3 +1 @@
 --relative
---no-2sp_soft_tabs-check
---no-arrow_alignment-check

Diff for: manifests/init.pp

@@ -29,10 +29,10 @@
   if $manage_postgresql_settings and (versioncmp('2018.1.0', $facts['pe_server_version']) > 0) {
     include pe_databases::postgresql_settings
     class { 'pe_databases::postgresql_settings::table_settings' :
-      manage_reports_autovacuum_cost_delay     => $pe_databases::postgresql_settings::manage_reports_autovacuum_cost_delay,
-      factsets_autovacuum_vacuum_scale_factor  => $pe_databases::postgresql_settings::factsets_autovacuum_vacuum_scale_factor,
-      reports_autovacuum_vacuum_scale_factor   => $pe_databases::postgresql_settings::reports_autovacuum_vacuum_scale_factor,
-      require                                  => Class['pe_databases::postgresql_settings'],
+      manage_reports_autovacuum_cost_delay    => $pe_databases::postgresql_settings::manage_reports_autovacuum_cost_delay,
+      factsets_autovacuum_vacuum_scale_factor => $pe_databases::postgresql_settings::factsets_autovacuum_vacuum_scale_factor,
+      reports_autovacuum_vacuum_scale_factor  => $pe_databases::postgresql_settings::reports_autovacuum_vacuum_scale_factor,
+      require                                 => Class['pe_databases::postgresql_settings'],
     }
   } elsif $manage_table_settings {
     # This is to provide for situations, like PE XL,

Diff for: manifests/maintenance/pg_repack.pp

@@ -18,8 +18,9 @@
 
   $postgresql_version = $facts['pe_postgresql_info']['installed_server_version']
   $repack_executable = versioncmp('2019.1.0', $facts['pe_server_version']) ? {
-                         1       => '/opt/puppetlabs/server/apps/postgresql/bin/pg_repack',
-                         default => "/opt/puppetlabs/server/apps/postgresql/${$postgresql_version}/bin/pg_repack" }
+                          1       => '/opt/puppetlabs/server/apps/postgresql/bin/pg_repack',
+                          default => "/opt/puppetlabs/server/apps/postgresql/${$postgresql_version}/bin/pg_repack"
+                          }
 
   $repack          = "su - pe-postgres -s /bin/bash -c \"${repack_executable} -d pe-puppetdb"
   $repack_jobs     = "--jobs ${jobs}"
@@ -28,8 +29,9 @@
   $catalogs_tables = '-t catalogs -t catalog_resources -t edges -t certnames"'
   $other_tables    = '-t producers -t resource_params -t resource_params_cache"'
   $reports_tables  = versioncmp('2019.1.0', $facts['pe_server_version']) ? {
-                       1       => '-t reports"',
-                       default => '-t reports -t resource_events"' }
+                        1       => '-t reports"',
+                        default => '-t reports -t resource_events"'
+                        }
   $logging         = "> ${logging_directory}/output.log 2>&1"
 
   Cron {
@@ -40,16 +42,16 @@
 
   cron { 'pg_repack facts tables' :
     weekday => [2,6],
-    hour     => 4,
-    minute   => 30,
-    command  => "${repack} ${repack_jobs} ${facts_tables} ${logging}",
+    hour    => 4,
+    minute  => 30,
+    command => "${repack} ${repack_jobs} ${facts_tables} ${logging}",
   }
 
   cron { 'pg_repack catalogs tables' :
-    weekday  => [0,4],
-    hour     => 4,
-    minute   => 30,
-    command  => "${repack} ${repack_jobs} ${catalogs_tables} ${logging}",
+    weekday => [0,4],
+    hour    => 4,
+    minute  => 30,
+    command => "${repack} ${repack_jobs} ${catalogs_tables} ${logging}",
   }
 
   cron { 'pg_repack other tables' :

Diff for: manifests/maintenance/vacuum_full.pp

@@ -29,23 +29,23 @@
   }
 
   Cron {
-    ensure   => $ensure_cron,
-    user     => 'root',
-    require  => File[$logging_directory, $script_directory],
+    ensure  => $ensure_cron,
+    user    => 'root',
+    require => File[$logging_directory, $script_directory],
   }
 
   cron { 'VACUUM FULL facts tables' :
-    weekday  => [2,6],
-    hour     => 4,
-    minute   => 30,
-    command  => "${vacuum_script_path} facts",
+    weekday => [2,6],
+    hour    => 4,
+    minute  => 30,
+    command => "${vacuum_script_path} facts",
   }
 
   cron { 'VACUUM FULL catalogs tables' :
-    weekday  => [0,4],
-    hour     => 4,
-    minute   => 30,
-    command  => "${vacuum_script_path} catalogs",
+    weekday => [0,4],
+    hour    => 4,
+    minute  => 30,
+    command => "${vacuum_script_path} catalogs",
   }
 
   cron { 'VACUUM FULL other tables' :

Diff for: manifests/postgresql_settings/table_settings.pp

@@ -4,12 +4,9 @@
 
 class pe_databases::postgresql_settings::table_settings (
   # lint:ignore:140chars
-  Boolean              $manage_reports_autovacuum_cost_delay     = lookup('pe_databases::postgresql_settings::manage_reports_autovacuum_cost_delay',
-                                                                     {'default_value' => true}),
-  Optional[Float[0,1]] $factsets_autovacuum_vacuum_scale_factor  = lookup('pe_databases::postgresql_settings::factsets_autovacuum_vacuum_scale_factor',
-                                                                     {'default_value' => 0.80}),
-  Optional[Float[0,1]] $reports_autovacuum_vacuum_scale_factor   = lookup('pe_databases::postgresql_settings::reports_autovacuum_vacuum_scale_factor',
-                                                                     {'default_value' => 0.01}),
+  Boolean              $manage_reports_autovacuum_cost_delay     = lookup('pe_databases::postgresql_settings::manage_reports_autovacuum_cost_delay',    {'default_value' => true}),
+  Optional[Float[0,1]] $factsets_autovacuum_vacuum_scale_factor  = lookup('pe_databases::postgresql_settings::factsets_autovacuum_vacuum_scale_factor', {'default_value' => 0.80}),
+  Optional[Float[0,1]] $reports_autovacuum_vacuum_scale_factor   = lookup('pe_databases::postgresql_settings::reports_autovacuum_vacuum_scale_factor',  {'default_value' => 0.01}),
   Optional[Float[0,1]] $catalogs_autovacuum_vacuum_scale_factor  = 0.75,
   Optional[Float[0,1]] $certnames_autovacuum_vacuum_scale_factor = 0.75,
   # lint:endignore