Eliminate convert configure_node_groups param #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidmv
changed the title
Previously, the user would need to specify the configure_node_groups parameter when running the convert plan. In some circumstances failing to pass the right value would break the convert operation. This commit adds computed default values for this parameter so that the user does not need to pass it.
reidmv
force-pushed
the
convert-improvements
branch
from
97d0bf7 to
f4d31d0
Compare
timidri
reviewed
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the user would need to specify the
configure_node_groupsparameter when running the convert plan. In some circumstances failing
to pass the right value would break the convert operation.
This commit adds computed default values for this parameter so that the
user does not need to pass it.