Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan steps #126

Merged
merged 3 commits into from
Sep 22, 2020
Merged

Plan steps #126

merged 3 commits into from
Sep 22, 2020

Conversation

reidmv
Copy link
Contributor

@reidmv reidmv commented Sep 21, 2020

Implement a mechanism for easy/fast/naive "resume" functionality by breaking plans apart into steps, and allowing the user to specify a begin_at_step parameter for the plan.

This PR defines the function, and implements it in the upgrade and convert plans.

@reidmv reidmv requested a review from a team as a code owner September 21, 2020 22:31
Copy link
Contributor

@timidri timidri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this feature is important enough to add to user-facing documentation.

Question: is it possible to make it so peadm records the last step it has completed so it can auto-restart where it left off the last time it ran?

@reidmv
Copy link
Contributor Author

reidmv commented Sep 22, 2020

Added documentation

This function lets a plan be broken down into steps, and a new parameter
allows starting the plan from a particular step, skipping any steps
occurring before it.
This allows convert to be run resuming at specified steps.
Added to upgrade and convert docs
@reidmv
Copy link
Contributor Author

reidmv commented Sep 22, 2020

An auto-restart is a possible future enhancement, but for now the intention is to keep things very simple. A step up from commenting out blocks of code.

@reidmv reidmv merged commit 8c27475 into main Sep 22, 2020
@reidmv reidmv deleted the plan-steps branch September 23, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants