Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make puppet_runonce exit non-zero on resrc failure #137

Merged
merged 1 commit into from
Dec 21, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tasks/puppet_runonce.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,15 @@ echo
--no-usecacheonfailure \
--no-splay \
--no-use_cached_catalog \
--detailed-exitcodes \
$NOOP_FLAG

# Without --detailed-exitcodes, the `puppet agent` command will return 0 even
# if there are resource failures. Use --detailed-exitcodes but only exit
# non-zero if an error occurred. Changes (code 2) are not errors.
exitcode=$?
if [ $exitcode -eq 0 -o $exitcode -eq 2 ]; then
exit 0
else
exit $exitcode
fi