Skip to content

Add peadm::backup plan #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 86 commits into from
Jan 24, 2022
Merged

Add peadm::backup plan #226

merged 86 commits into from
Jan 24, 2022

Conversation

davidsandilands
Copy link
Contributor

A plan that backs up user data, I have tested over the three standard architectures varying what was being backed up and where.

Note it will fail if the backup directory doesn't exist and database backups will fail if pe-postgres doesn't have access to the directory

davidsandilands and others added 25 commits January 5, 2022 10:06
Change backup to output directory for better naming

Co-authored-by: Reid Vandewiele <[email protected]>
Changing variable name

Co-authored-by: Reid Vandewiele <[email protected]>
Changing variable name

Co-authored-by: Reid Vandewiele <[email protected]>
Changing variable name

Co-authored-by: Reid Vandewiele <[email protected]>
Copy link
Contributor

@reidmv reidmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

I will say, an improvement we can probably make would be to use the peadm::get_peadm_config task to automatically calculate values for replica host, compiler hosts, postgresql host(s), etc. That way, we could run the backup task with just the primary_host parameter as the only required input.

@reidmv
Copy link
Contributor

reidmv commented Jan 24, 2022

I'm going to squash and merge for now. Let's consider peadm::get_peadm_config for an easy incremental improvement though.

@reidmv reidmv merged commit f5cef7a into main Jan 24, 2022
@reidmv reidmv deleted the SOLARCH-564 branch January 24, 2022 16:44
@reidmv reidmv changed the title Solarch-564 adding plan to backup data Add peadm::backup plan Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants