-
Notifications
You must be signed in to change notification settings - Fork 54
Add peadm::backup
plan
#226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change backup to output directory for better naming Co-authored-by: Reid Vandewiele <[email protected]>
Changing variable name Co-authored-by: Reid Vandewiele <[email protected]>
Changing variable name Co-authored-by: Reid Vandewiele <[email protected]>
Changing variable name Co-authored-by: Reid Vandewiele <[email protected]>
…fixed remote puppetdb backup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
I will say, an improvement we can probably make would be to use the peadm::get_peadm_config
task to automatically calculate values for replica host, compiler hosts, postgresql host(s), etc. That way, we could run the backup task with just the primary_host
parameter as the only required input.
I'm going to squash and merge for now. Let's consider |
A plan that backs up user data, I have tested over the three standard architectures varying what was being backed up and where.
Note it will fail if the backup directory doesn't exist and database backups will fail if pe-postgres doesn't have access to the directory