Make versions match SemVer pattern #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ooh, wait a moment... we can't do quite this. We need to accomodate development builds too. So, the Regex needs to be adjusted for that. |
reidmv
force-pushed
the
require-semver-version
branch
from
ea3e857 to
98cbbb2
Compare
All PE version downloads need to match the x.y.z format. This commit changes the type specifier to require this format. This is especially useful to help guide people to the right parameters if they specify a version like "2022.4" instead of "2022.4.0".
reidmv
force-pushed
the
require-semver-version
branch
from
98cbbb2 to
c239bc7
Compare
timidri
reviewed
Mar 4, 2022
| @@ -26,7 +26,7 @@ | |||
|
|
|||
| # Common Configuration | |||
| String $console_password, | |||
| String $version = '2019.8.8', | |||
| Peadm::Pe_version $version = '2019.8.8', | |||
There was a problem hiding this comment.
This should probably be 2019.8.10 or 2021.5.0. Speaking of which, can we make the default auto-updating somehow?
There was a problem hiding this comment.
We should ideally make auto-updating a thing, yeah. That's probably a piece of work by itself, and would ideally include/encompass plan parameter version defaults, CI job version defaults, and validation functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All PE version downloads need to match the x.y.z format. This commit
changes the type specifier to require this format.
This is especially useful to help guide people to the right parameters
if they specify a version like "2022.4" instead of "2022.4.0".