Add support for SLES 12 #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@puppetlabs/solutions-architecture @MartyEwings should we update metadata.json? |
Contributor
Author
yeah ill do that now |
davidsandilands
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit when run against a SLES platform, peadm::download would assume the platform was EL based and form a url that was the SLES version number with the EL os family, and ultimately Fail.
This commit adds logic to detect SLES, it leaves EL detection in an "else" catch all, but this is only problematic if the plan is run against an unsupported Primary OS Family, and maintains existing behavior.
this commit is brought to you by "works for me" level testing, in that i have successfully spun up Stadard EL / sles / and Ubuntu environments with this modification