Add experimental restore plan #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidmv
force-pushed
the
SOLARCH-581
branch
6 times, most recently
from
0b13e7c to
b03ac49
Compare
This commit holds WIP for the peadm::restore plan.
This commit refactors the restore plan for style (line folding, variable names, etc) and flow, mainly an attempt to find a single path that always works, and eliminate conditional logic. The plan is not yet validated at this stage. More work is required to ensure correct functionality.
WIP: doing testing/validation and fixing logic
Because the PuppetDB database exists separately on two PostgreSQL hosts in a DR configuration, adapt the restore plan to restore the data to BOTH locations, if they exist
Specifically, make it handle situations where PuppetDB queries return multiple results for server() queries, which could happen in the event a database has been backed up on one cluster, and restored into another.
Note what additional action needs to take place when there is dev time
This should help keep current cluster PuppetDB knowledge of cluster hosts after restoring PuppetDB data from a backup
They aren't ready yet for full use
davidsandilands
approved these changes
May 6, 2022
reidmv
changed the title
reidmv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit holds WIP for the peadm::restore plan.