Add task and update configure plan to allow for ldap configuration on… #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
reidmv
approved these changes
May 10, 2022
There was a problem hiding this comment.
Looks great to me. Thanks for contributing this @bwilcox!
I added some commits to adjust how this is documented, and switch to using a type alias for validation/documentation rather than relying much on the markdown. Can you take a quick look? If we get your 👍 for that, we'll go ahead and get this merged.
reidmv
approved these changes
May 11, 2022
Keep the top-of-line documentation simple, but supply additional hints as to how to configure ldap via a type alias (struct) as well as a yardoc link to the relevant API documentation.
|
Thanks for the update Reid! I think the type is a much better way to handle validation for the config input. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a task for configuring the ldap service on installation.
There is error checking to catch when the ldap configuration does not take. This will notify the user, but
not stop the install process.
Also added an example of a peadm.json file which includes the ldap configuration hash.