Changed for more reliable hostname resolution #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `hostnamectl --transient` doesn't *always* return the FQDN, which is what the plans are usually expecting. `hostname -f` is a more reliable way of doing this. Fixes puppetlabs#22
reidmv
approved these changes
Oct 30, 2019
There was a problem hiding this comment.
I tried to see if there was a simple way to do exactly what Facter would do, but turns out ...there's not. So this is about as good as it gets for now.
A future refinement could be to allow setting the Puppet certname so that it doesn't have to match apriori. Not a need-to-have. 👍 on this improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
hostnamectl --transientdoesn't always return the FQDN, which is what the plans are usually expecting.hostname -fis a more reliable way of doing this.Fixes #22