Skip to content

allow to customize admin's token lifetime #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ody merged 1 commit into from
Sep 13, 2022
Merged

allow to customize admin's token lifetime #285

ody merged 1 commit into from
Sep 13, 2022

Conversation

@vchepkov
Copy link
Contributor

@vchepkov vchepkov commented Sep 10, 2022

No description provided.

@vchepkov vchepkov requested a review from a team as a code owner September 10, 2022 12:43
timidri
timidri approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@timidri timidri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution @vchepkov !

@timidri
Copy link
Contributor

timidri commented Sep 12, 2022

@ody The CI test fails with:

Failed on 35.203.179.121:
  The task failed with exit code 1
  Check for and wait up to 5 minutes for in-progress run to complete
  Notice: Run of Puppet configuration client already in progress; skipping  (/opt/puppetlabs/puppet/cache/state/agent_catalog_run.lock exists)
Failed on 1 target: 35.203.179.121
Ran on 1 target
Error: Process completed with exit code 1.

Did we see this kind of error before? Do you have any ideas about what the root cause might be? A Puppet run running longer than 5 minutes or one that is stale or stuck?

@ody ody merged commit 57f5a9b into puppetlabs:main Sep 13, 2022
@vchepkov vchepkov deleted the token branch September 14, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@timidri timidri timidri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vchepkov @timidri @ody