Skip to content

(PE-40508) Add infra-assistant to add_database plan #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2025

Conversation

abottchen
Copy link
Contributor

@abottchen abottchen commented Apr 10, 2025

Summary

Adding the Infra Assistant DB following just as was done with PE Patching in #531.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.

Changes include test coverage?

  • Yes
  • Not needed

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

@abottchen
Copy link
Contributor Author

The Ubuntu test failures are due to a bad GPG key in the Ubuntu nightly images. These tests need to point to images with updated keys.

@abottchen abottchen marked this pull request as ready for review April 15, 2025 17:59
@abottchen abottchen requested review from a team as code owners April 15, 2025 17:59
# The infra-assistant was added in 2025.3.0
$pe_2025_3_or_later: {
$original_db_names + [
'pe-infra-assistant',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puppet case statements don't fall through so I think you need to include all of the previous dbs: pe-hac and pe-patching here as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah crap, thanks for catching that.

Adding the Infra Assistant DB following just as was done with PE
Patching in #531.
@abottchen abottchen force-pushed the pe-40508/add-infra-assistant-to-add-database-plan branch from 838a6a6 to 5273d90 Compare April 15, 2025 20:29
Neil Anderson and others added 2 commits April 25, 2025 11:44
Currently issue in main causing problem in peadm ci
@ragingra ragingra marked this pull request as draft April 25, 2025 10:51
@ragingra ragingra marked this pull request as ready for review April 25, 2025 10:51
@abottchen abottchen merged commit 2817444 into main Apr 28, 2025
2 checks passed
@abottchen abottchen deleted the pe-40508/add-infra-assistant-to-add-database-plan branch April 28, 2025 18:07
B00885424 added a commit that referenced this pull request May 6, 2025
…n debugging. hosts, pe version,

include logs as allowed in 'basic functionality'

expect the out message

PE-40508) Add infra-assistant to add_database plan (#580)

Co-authored-by: Neil Anderson <[email protected]>
Co-authored-by: ragingra <[email protected]>

add XL with and without DR to test migration and migrate plans (#581)
B00885424 added a commit that referenced this pull request May 6, 2025
…n debugging. hosts, pe version,

include logs as allowed in 'basic functionality'

expect the out message

PE-40508) Add infra-assistant to add_database plan (#580)

Co-authored-by: Neil Anderson <[email protected]>
Co-authored-by: ragingra <[email protected]>

add XL with and without DR to test migration and migrate plans (#581)
B00885424 added a commit that referenced this pull request May 6, 2025
…n debugging. hosts, pe version,

PE-40508) Add infra-assistant to add_database plan (#580)

Co-authored-by: Neil Anderson <[email protected]>
Co-authored-by: ragingra <[email protected]>

add XL with and without DR to test migration and migrate plans (#581)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants