Skip to content

(CONT-904) - Removal of tech debt #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2023
Merged

(CONT-904) - Removal of tech debt #1429

merged 2 commits into from
May 2, 2023

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented May 2, 2023

Fixes a bug where non-array values passed to 'object_name' did not work and returned unknown variable "$_togrant_object_only".

Removes the now redundant temporary fix introduced in a098797

@jordanbreen28 jordanbreen28 requested a review from a team as a code owner May 2, 2023 12:15
@jordanbreen28 jordanbreen28 self-assigned this May 2, 2023
@jordanbreen28 jordanbreen28 force-pushed the CONT-904-Fix_onlyif_exists branch 3 times, most recently from f82cabc to 4184754 Compare May 2, 2023 12:18
@jordanbreen28 jordanbreen28 force-pushed the CONT-904-Fix_onlyif_exists branch from 4184754 to 39695ec Compare May 2, 2023 15:11
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Fixes a bug where non-array values passed to 'object_name' did not work
and returned unknown variable "$_togrant_object_only".

The correcting of this bug means the temporary fix to disable strict
checking can now be removed.
@jordanbreen28 jordanbreen28 force-pushed the CONT-904-Fix_onlyif_exists branch from 39695ec to 224a8c4 Compare May 2, 2023 15:43
@chelnak chelnak merged commit 7468db0 into main May 2, 2023
@chelnak chelnak deleted the CONT-904-Fix_onlyif_exists branch May 2, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants