Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused validate_postgresql_connection.sh script #1632

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions files/validate_postgresql_connection.sh

This file was deleted.

8 changes: 2 additions & 6 deletions manifests/client.pp
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
# @param file_ensure
# Ensure the connection validation script is present
# @param validcon_script_path
# Optional. Absolute path for the postgresql connection validation script.
# Deprecated: absolute path for the postgresql connection validation script that is now ensured absent.
# @param package_name
# Sets the name of the PostgreSQL client package.
# @param package_ensure
Expand All @@ -26,10 +26,6 @@
}

file { $validcon_script_path:
ensure => $file_ensure,
content => file('postgresql/validate_postgresql_connection.sh'),
owner => 0,
group => 0,
mode => '0755',
ensure => absent,
}
}
2 changes: 1 addition & 1 deletion manifests/globals.pp
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
# @param service_status Overrides the default status check command for your PostgreSQL service.
# @param default_database Specifies the name of the default database to connect with.
#
# @param validcon_script_path Scipt path for the connection validation check.
# @param validcon_script_path Deprecated parameter for the scipt path for the connection validation check. This file will be ensured absent
#
# @param initdb_path Path to the initdb command.
# @param psql_path Sets the path to the psql command.
Expand Down
5 changes: 1 addition & 4 deletions spec/classes/client_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,7 @@
end

it 'has specified validate connexion' do
expect(subject).to contain_file('/opt/bin/my-validate-con.sh').with(ensure: 'file',
owner: 0,
group: 0,
mode: '0755')
expect(subject).to contain_file('/opt/bin/my-validate-con.sh').with(ensure: 'absent')
end
end

Expand Down
Loading