(PA-6627) Update the first released version for released platforms in… #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you elaborate a bit why you do this change? |
We add a new platform in |
shubhamshinde360
approved these changes
Jun 27, 2024
|
That information belongs in the commit message. It is very unclear from the commit message what the refactor is doing. |
mhashizume
added
the
maintenance
shubhamshinde360
force-pushed
the
PA-6627
branch
3 times, most recently
from
26daa5f to
5e34bf3
Compare
… spec We add a new platform in 'latest_platform_list' method so that it considers builds from nightlies with the 'latest' tag before they are released (since the versioned release package won't be available for new platforms). The platforms which are no more new and have been released are removed from 'latest_platform_list' here along with their first released versions specified as needed. We also test upgrade from the first released puppet7 version to the latest released puppet7 version. The new platforms only have one release, so this test is not applicable for them. Removed platforms which have had multiple puppet7 versions released as of now to make the test applicable for them. This is done by setting the 'multiple_puppet7_versions' parameter to true.
shubhamshinde360
force-pushed
the
PA-6627
branch
from
5e34bf3 to
0e273cf
Compare
|
@bastelfreak, @donoghuc Could you please take a look, added more info in the commit message. Thanks! |
joshcooper
approved these changes
Jun 28, 2024
donoghuc
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… spec
We add a new platform in 'latest_platform_list' method so that it considers builds from nightlies with the 'latest' tag before they are released (since the versioned release package won't be available for new platforms). The platforms which are no more new and have been released are removed from 'latest_platform_list' here along with their first released versions specified as needed.
We also test upgrade from the first released puppet7 version to the latest released puppet7 version. The new platforms only have one release, so this test is not applicable for them. Removed platforms which have had multiple puppet7 versions released as of now to make the test applicable for them. This is done by setting the 'multiple_puppet7_versions' parameter to true.
Tested this on local. Ad-hoc pipeline isn't available at this stage.
Updated release version according to https://perforce.atlassian.net/wiki/spaces/PUPPROD/pages/371851628/Currently+Supported+OS+Platforms