Skip to content

(ITHELP-116185) Add fix dns step to Task Acceptance Tests workflow #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025

Conversation

AriaXLi
Copy link
Contributor

@AriaXLi AriaXLi commented Jul 21, 2025

In the Task Acceptance Tests workflow, Twingate was having trouble connecting to Artifactory due to running the job in Docker containers. The Docker containers used in the workflow run on Azure VM's and Microsoft adds their own nameservers, 168.63.129.16. It gets copied to resolv.conf and interferes with Twingate which caused DNS resolution failures with Artifactory.

To resolve this, this commit adds a "Fix DNS" step that removes the Azure DNS name server and adds Twingate's DNS server.

https://github.com/marketplace/actions/connect-to-twingate#actions-running-docker-steps-that-require-access-to-a-twingate-resource

@AriaXLi AriaXLi requested review from bastelfreak and a team as code owners July 21, 2025 23:31
@AriaXLi AriaXLi force-pushed the twingate_artifactory branch from 81d544a to a291039 Compare July 22, 2025 19:23
@AriaXLi AriaXLi changed the title WIP (ITHELP-116185) Add fix dns step to Task Acceptance Tests workflow Jul 22, 2025
@AriaXLi AriaXLi force-pushed the twingate_artifactory branch from a291039 to 0c57b25 Compare July 22, 2025 19:26
@AriaXLi AriaXLi added the maintenance Maintenance chores are typically excluded from changelogs label Jul 22, 2025
@AriaXLi AriaXLi force-pushed the twingate_artifactory branch from 0c57b25 to 3fcfb86 Compare July 22, 2025 20:09
In the Task Acceptance Tests workflow, Twingate was having trouble connecting
to Artifactory due to running the job in Docker containers. The Docker
containers used in the workflow run on Azure VM's and Microsoft adds their own
nameservers, 168.63.129.16. It gets copied to resolv.conf and interferes with
Twingate which caused DNS resolution failures with Artifactory.

To resolve this, this commit adds a "Fix DNS" step that removes the Azure DNS
name server and adds Twingate's DNS server.
@AriaXLi AriaXLi force-pushed the twingate_artifactory branch from 3fcfb86 to 37ec30f Compare July 22, 2025 20:10
@joshcooper joshcooper merged commit 0d52b3d into main Jul 23, 2025
16 checks passed
@joshcooper joshcooper deleted the twingate_artifactory branch July 23, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance chores are typically excluded from changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants