(PE-40346) Fix retrieve_additional_metrics error handling #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conversion to JSON prior to making a HTTP request was not the error reported in SUP-5232. JSON responses that did not contain Array bodies were the cause of the issue. This reverts commit 05cf01b.
This commit adds a guard clause to the `retrieve_additional_metrics` function in `pe_metrics.rb` that ensures the data returned from the `/metrics` API is of type Array. Non-conforming data is logged to stderr along with the URL queried as non-Array responses typically contain error messages that inform why the request failed.
Sharpie
force-pushed
the
PE-40346-fix-pe_metrics-error-handling
branch
from
1b37c06 to
137a00c
Compare
steveax
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a guard clause to the
retrieve_additional_metricsfunction in
pe_metrics.rbthat ensures the data returned from the/metricsAPI is of type Array.Non-conforming data is logged to stderr along with the URL queried
as non-Array responses typically contain error messages that inform
why the request failed.