(PE-40043) Remove faulty index bloat statistics #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes index bloat estimates added in SUP-2115 from `psql_metrics`. Collection of this data can result in some amount of temporary files written to disk every 5 minutes due to the nested group and sort operations involved. The bloat values generated were also of questionable quality producing both "reasonable" numbers like 50% bloat and absolutely unusable numbers like -230% bloat. The table bloat estimate is retained as the query there is less complicated, operates directly on postgres page counts and fill percentages, and does not produce the same negative estimates that the index bloat query is generating. This partially reverts commit 7497949.
steveax
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes index bloat estimates added in SUP-2115 from
psql_metrics. Collection of this data can result in some amount of temporary files written to disk every 5 minutes due to the nested group and sort operations involved. The bloat values generated were also of questionable quality producing both "reasonable" numbers like 50% bloat and absolutely unusable numbers like -230% bloat.The table bloat estimate is retained as the query there is less complicated, operates directly on postgres page counts and fill percentages, and does not produce the same negative estimates that the index bloat query is generating.
This partially reverts commit 7497949.