Ship directly to influx #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, there was no built-in way to ship metrics to an outside metrics server. After this commit, we pull in a script from puppetlabs/puppet-metrics-viewer that allows conversion of the metrics data we gather to influxdb or graphite format. This commit adds the initial support to enabling shipping of metrics directly to influxdb when given a hostname to connect to.
Previously, we only allowed passing an influxdb host but you may want to pass a port or a different database type for influx. Additionally, you may prefer to ship to graphite. You can now do any of these by using the correct metrics_server_info hash.
…tps://github.com/npwalker/pe_metric_curl_cron_jobs into ship_directly_to_influx
|
I took a brief look at this and it looks pretty great. I'll test this out this week and put in a review. |
HelenCampbell
pushed a commit
to puppetlabs/puppetlabs-splunk_hec
that referenced
this pull request
May 17, 2019
This commit adds the splunk_hec puppet face/app allowing for a cat json | puppet splunk_hec like workflow. The first functionality of this code is to enable sending pe metrics data to Splunk using the current CS best practices for collecting the CS data. This will need changes in the puppet metrics collector module managed by CS to enable that specific workflow: puppetlabs/puppetlabs-puppet_metrics_collector#6 This also adds the transaction_uuid to the fact event submission, so correlation of facts created, the catalog, and the report are now possible. This introduces an epochtime function to ensure that across all of our event submission code, we're always generating a timestamp of the same precision and in the same way.
jarretlavallee
suggested changes
Jun 12, 2019
| true => $local_metrics_command, | ||
| } | ||
|
|
||
| $metrics_command = $metrics_server_type ? { |
There was a problem hiding this comment.
This command should redirect STDOUT to /dev/null otherwise it will spam the /var/spool/mail/root every run.
| @@ -15,6 +15,7 @@ | |||
| Array[String] $activemq_hosts = [ '127.0.0.1' ], | |||
| Integer $activemq_port = 8161, | |||
| Boolean $symlink_puppet_metrics_collector = true, | |||
| Optional[Puppet_metrics_collector::Metrics_server] $metrics_server_info = undef, | |||
There was a problem hiding this comment.
The format for this parameter needs to be documented in the readme as well as an example.
| @@ -0,0 +1,362 @@ | |||
| #!/opt/puppetlabs/puppet/bin/ruby | |||
There was a problem hiding this comment.
There were some new changes to this file in puppetlabs/puppet-metrics-viewer#28 that should be synced over. What process should we use to ensure these are both in sync?
| fail( 'When using an influxdb server you must provide the db_name to store metrics in' ) | ||
| } | ||
|
|
||
| $local_metrics_command = "${metrics_base_command} | ${conversion_script_file_name} --netcat ${metrics_server_hostname} --convert-to ${metrics_server_type}" |
There was a problem hiding this comment.
Can we make this command overridable by a parameter? It would be nice to specify this for external tools like puppetlabs/puppetlabs-splunk_hec@b39cd4e
|
Closing in favor of #19 which has the changes and a rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting npwalker/pe_metric_curl_cron_jobs#48 to puppet_metrics_collector