Remove obsolete database config options

[smokris]

When I install and configure PuppetDB 7.11.0 (latest) using PuppetDB Puppet Module version 7.10.0 (latest), PuppetDB emits these warnings:

The [database] classname config option has been retired and will be ignored.
The [database] conn-keep-alive config option has been retired and will be ignored.
The [database] log-slow-statements config option has been retired and will be ignored.
The [database] subprotocol config option has been retired and will be ignored.
The [read-database] classname config option has been retired and will be ignored.
The [read-database] conn-keep-alive config option has been retired and will be ignored.
The [read-database] log-slow-statements config option has been retired and will be ignored.
The [read-database] subprotocol config option has been retired and will be ignored.

This PR removes the ini_setting resources for those database config options.

[puppet-community-rangefinder]

puppetdb is a class

Breaking changes to this file WILL impact these 6 modules (exact match):

• abstractit-puppet
• simp-simp
• ploperations-puppet
• neillturner-foreman_puppetdb
• aursu-puppet
• puppetfinland-puppetmaster

Breaking changes to this file MAY impact these 2 modules (near match):

• example42-psick
• devopera-dopuppetmaster

puppetdb::params is a class

that may have no external impact to Forge modules.

puppetdb::server is a class

that may have no external impact to Forge modules.

puppetdb::server::database is a class

that may have no external impact to Forge modules.

puppetdb::server::read_database is a class

that may have no external impact to Forge modules.

This module is declared in 33 of 579 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[CLAassistant]

All committers have signed the CLA.

[alexjfisher]

It gets worse... puppetlabs/puppetdb#4017 :(