use apt keyring instead of trusted.d #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trying to follow the recommendations from https://wiki.debian.org/DebianRepository/UseThirdParty
|
I want to acknowledge this PR and thank you for it. On the surface, it looks good to me. However, it will likely be a few weeks before I can properly test and approve it. |
e-gris
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I'm trying to follow the recommendations from https://wiki.debian.org/DebianRepository/UseThirdParty to move away from trusted.d and use signed-by option with keyrings.
This should solve some error encountered when using puppetlabs-puppet module since the merge of puppetlabs/puppetlabs-puppet_agent#681 (eg. puppetlabs/puppetlabs-puppet_agent#681 (comment))
I was still not sure if in the case of puppetlabs-release we should rather put the keyring in
/etc/apt/keyringsor/usr/share/keyrings, feel free to correct me if needed.