Skip to content

Commit

Permalink
compiler.rb: Switch to modern facts
Browse files Browse the repository at this point in the history
All of those are available at least since Facter 3.
  • Loading branch information
bastelfreak committed Sep 13, 2024
1 parent fd9f03b commit bf2b13c
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/ruby/puppetserver-lib/puppet/server/compiler.rb
Original file line number Diff line number Diff line change
Expand Up @@ -239,9 +239,9 @@ def set_server_facts
@server_facts['serverversion'] = Puppet.version.to_s

# And then add the server name and IP
{ 'servername' => 'fqdn',
'serverip' => 'ipaddress',
'serverip6' => 'ipaddress6'
{ 'servername' => 'networking.fqdn',
'serverip' => 'networking.ip',
'serverip6' => 'networking.ip6'
}.each do |var, fact|
value = Facter.value(fact)
if value
Expand All @@ -250,10 +250,10 @@ def set_server_facts
end

if @server_facts['servername'].nil?
host = Facter.value(:hostname)
host = Facter.value('networking.hostname')
if host.nil?
Puppet.warning _("Could not retrieve fact servername")
elsif domain = Facter.value(:domain)
elsif domain = Facter.value('networking.domain')
@server_facts['servername'] = [host, domain].join('.')
else
@server_facts['servername'] = host
Expand Down

0 comments on commit bf2b13c

Please sign in to comment.