Refactor puppetserver container tests #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on puppetlabs/pupperware#65 |
underscorgan
force-pushed
the
maint/master/container-spec-cleanup
branch
5 times, most recently
from
f8466f8 to
f8813c5
Compare
added 2 commits
May 3, 2019 14:14
This updates the puppetserver tests to use `docker-compose` instead of `docker-run`. This also updates the tests to use the shared testing gem from github.com/puppetlabs/pupperware. This also includes a move from the puppet-agent-alpine to puppet-agent-ubuntu for testing. We were seeing a lot of intermittent network failures with the alpine container on windows (LCOW). See moby/libnetwork#2371 and microsoft/opengcs#303 have more information on this issue. This should hopefully clear up the intermittent name resolution failures we were seeing.
This adds `PUPPET_STORECONFIGS_BACKEND`, `PUPPET_STORECONFIGS`, and `PUPPET_REPORTS` environment variables for configuring `storeconfigs_backend`, `storeconfigs`, and `reports` settings in puppet.conf.
underscorgan
force-pushed
the
maint/master/container-spec-cleanup
branch
from
f8813c5 to
aad85a0
Compare
|
This is ready for review now :) |
Iristyle
reviewed
May 3, 2019
| - PUPPETSERVER_HOSTNAME=puppet.test | ||
| - PUPPERWARE_ANALYTICS_ENABLED=${PUPPERWARE_ANALYTICS_ENABLED:-false} | ||
| - DNS_ALT_NAMES=puppet,puppet.test,${DNS_ALT_NAMES:-} | ||
| dns_search: '.test' |
There was a problem hiding this comment.
It's interesting that this works, because I thought what I discovered in my experiments was that this is actually supposed to be:
dns_search: test
Iristyle
reviewed
May 3, 2019
| - compiler.test | ||
|
|
||
| networks: | ||
| puppetserver_test: |
There was a problem hiding this comment.
👍
Even though this adds more to the file, we should probably make this explicit it in other compose files so we have better control of the name.
Iristyle
approved these changes
May 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.