(PE-37145) ensure schema failures are verbosely logged #2824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, a failure in schema checks would provide minimal useful context in the logs around what the schema error was. This adds specific handling for schema failures to log them more verbosely as well as forming a json error payload that contains the schema failures. Prior to this change, the default handler for jetty was generating a generic error page with the schema failure. Given that the consumers of this endpoint are not often webbrowsers, this form of content was deemed less useful than a json response with the details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, a failure in schema checks would provide minimal useful context in the logs around what the schema error was. This adds specific handling for schema failures to log them more verbosely as well as forming a json error payload that contains the schema failures.
Prior to this change, the default handler for jetty was generating a generic error page with the schema failure. Given that the consumers of this endpoint are not often webbrowsers, this form of content was deemed less useful than a json response with the details.